chore: Elm theme Improvements on Discussion Module #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These test cases are fixed in #55 |
omerhabib26
requested review from
k1rill,
dixidroid,
farhan-arshad-dev and
HamzaIsrar12
HamzaIsrar12
requested changes
Oct 8, 2024
There was a problem hiding this comment.
Manual Review:
- The follow button is functioning perfectly (light/dark).
- The selected state color for the like button needs updating; it currently appears dim (light/dark).
- The disabled state for the send button only affects the background orange color and not the white icon (dark).
- The create button does not have a disabled state (light/dark).
HamzaIsrar12
approved these changes
Oct 9, 2024
dixidroid
approved these changes
Oct 10, 2024
- Update Text, icons colors and button according to elm theme fix: LEARNER-10080
omerhabib26
force-pushed
the
2U/omer/LEARNER-10080
branch
from
eb05181 to
a4376c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
fix: LEARNER-10080